Assistant: Change flags name #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JF-Cozy
requested review from
cballevre,
Ldoppea and
doubleface
as code owners
BundleMonFiles updated (1)
Unchanged files (12)
Total files change +27B 0% Final result: ✅ View report in BundleMon website ➡️ |
Ldoppea
approved these changes
Oct 28, 2024
Comment on lines
+98
to
+100
| const showAssistantForMobile = isFlagshipApp() | ||
| ? flag('cozy.searchbar.enabled-for-flagship') | ||
| : flag('cozy.searchbar.enabled') && isMobile |
There was a problem hiding this comment.
La variable showAssistantForMobile devrait plutôt s'appeler showSearchbarForMobile du coup?
There was a problem hiding this comment.
oui mais à ce compte là faudrait renommer les composants également... en fait "assistant" est parfois un mot générique pour toute la feature, parfois parle spécifiquement de la partie chat... je pense faire ça dans une autre PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permet d'apporter un peu plus de granularité dans la gestion des fonctionnalités
cozy.searchbar.enabled: Affiche la barre de recherche (uniquement desktop/mobile web)cozy.searchbar.enabled-for-flagship: Affiche la barre de recherche (uniquement flagship app)cozy.search.enabled: Active la fonction de recherchecozy.assistant.enabled: Active la fonctionnalité "Cozy Assistant"